fix!: require a working CodePush server URL - #41
Merged
Conversation
App Center's default endpoint is retired. Prebuild now fails on Android and iOS when CodePushServerURL is missing, before it can produce a native build that cannot fetch updates. BREAKING CHANGE: Both Android and iOS CodePushServerURL values are required.
Owner
Author
|
Packed-tarball proof from
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix!: require a working CodePush server URL
Summary
Prebuild now requires a self-hosted CodePush server URL for Android and iOS, and stops with an actionable error before it can write config for App Center's retired endpoint.
Details
Testing steps
From the repository root, run:
pnpm install --frozen-lockfile pnpm run testConfirm every command exits successfully. The test output should show Android and iOS rejecting both missing and empty update server addresses.